added note about docker and go dependency to the readme #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,6 +217,10 @@ kubectl create -f scope-probe-ds.yaml | |||
|
|
|||
| ## <a name="developing"></a>Developing | |||
|
|
|||
| Building scope from source depends on the latest versions of | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Minor-comment, LGTM. |
| @@ -217,6 +217,10 @@ kubectl create -f scope-probe-ds.yaml | |||
|
|
|||
| ## <a name="developing"></a>Developing | |||
|
|
|||
| Building scope from source depends on the latest versions of | |||
| [docker](https://www.docker.com/) and [go](https://golang.org/), so | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
readme-dependencies
branch
from
cc46795 to
61906ae
Compare
paulbellamy
force-pushed
the
readme-dependencies
branch
from
61906ae to
0a383d7
Compare
|
removed dependency on go on the host, and clarified the relationship between @davkal does this still work for you? |
|
Still works, @paulbellamy thx |
| container, builds the backend build container, builds the app and probe in a | ||
| said container, and finally pushes the lot into a Docker image called | ||
| **weaveworks/scope**. | ||
| Building Scope from source depends on the latest version of |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
added a commit
that referenced
this pull request
Feb 19, 2016
added note about docker and go dependency to the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.